Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crystal language support #4993

Merged
merged 5 commits into from
Dec 17, 2022
Merged

Conversation

Jomy10
Copy link
Contributor

@Jomy10 Jomy10 commented Dec 3, 2022

I added syntax highlighting for the Crystal language.

Note that some syntax highlighting is missing due to the tree sitter not being complete yet.

@pascalkuthe pascalkuthe added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Dec 3, 2022
.gitignore Outdated Show resolved Hide resolved
runtime/queries/crystal/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/crystal/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/crystal/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/crystal/highlights.scm Outdated Show resolved Hide resolved
@archseer
Copy link
Member

archseer commented Dec 5, 2022

Need to also run cargo xtask docgen

@Jomy10
Copy link
Contributor Author

Jomy10 commented Dec 10, 2022

I have implemented the requested changes.

runtime/queries/crystal/highlights.scm Outdated Show resolved Hide resolved
languages.toml Outdated Show resolved Hide resolved
@Jomy10 Jomy10 requested a review from the-mikedavis December 17, 2022 11:34
@the-mikedavis the-mikedavis merged commit aecb524 into helix-editor:master Dec 17, 2022
@the-mikedavis
Copy link
Member

Thanks!

gibbz00 pushed a commit to gibbz00/helix that referenced this pull request Dec 17, 2022
hadronized pushed a commit to hadronized/helix that referenced this pull request Jan 4, 2023
freqmod pushed a commit to freqmod/helix that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants